Implemented MVVM on update_profile_page_view.dart #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2021
Closed
palisadoes
requested review from
MrSambo,
dellyjm,
DeltaHarbinger and
Sagar2366
and removed request for
MrSambo
… into update-profile-page-MVVM
… into update-profile-page-MVVM
|
@dellyjm Please review this |
|
@rutvik11062000 linter check is failing, resolve conflicts on PR. |
… into update-profile-page-MVVM
|
@Dev-Dominic please take a look |
|
@rutvik11062000 please resolve the conflicts |
… into update-profile-page-MVVM
… into update-profile-page-MVVM
… into update-profile-page-MVVM
Done sir. |
|
@rutvik11062000 |
… into update-profile-page-MVVM
|
@rutvik11062000 The Travis integration is failing. |
Yes sir, I just fixed it. |
palisadoes
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Structurally added Model-View-ViewModel layers in "Update Profile" page.
Did you add tests for your changes?
Yes, Updated the update profile page test.
If relevant, did you update the documentation?
Summary
For ease of testing and separation of different layers to make a logical data flow and error handling.
Does this PR introduce a breaking change?
No.
Other information
There was an exception of
updateUserProfile" on type mutationeven before these PR changes.Once develop and master branch merges this error will be not there and user can update their profiles.
Resolves: #758